-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute: VM.waitFor() #2047
Merged
Merged
compute: VM.waitFor() #2047
Commits on Apr 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 1854a24 - Browse repository at this point
Copy the full SHA 1854a24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f2541f - Browse repository at this point
Copy the full SHA 6f2541fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7531026 - Browse repository at this point
Copy the full SHA 7531026View commit details -
Previously, this would set the timeout to the default of 300 if the timeout was set to 0. Fixed so that it only checks to see if timeout is not set. Added JSdoc comments clarifying that if the options.timeout is set to 0, it will poll once and then timeout if the state is not reached.
Configuration menu - View commit details
-
Copy full SHA for aafd09b - Browse repository at this point
Copy the full SHA aafd09bView commit details -
WAIT_FOR_POLLING_INTERVAL and VALD_STATUSES should be set to private.
Configuration menu - View commit details
-
Copy full SHA for 6cffe29 - Browse repository at this point
Copy the full SHA 6cffe29View commit details -
An invalid status now throws an Error, since this is a problem with how the function is called (like detatchDisk() does) A time out will return an Error in the callback , with the appropriate message, code, and name.
Configuration menu - View commit details
-
Copy full SHA for 15ce07b - Browse repository at this point
Copy the full SHA 15ce07bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aeead3 - Browse repository at this point
Copy the full SHA 9aeead3View commit details -
There is no apiResponse passed to the callback.
Configuration menu - View commit details
-
Copy full SHA for bf0095b - Browse repository at this point
Copy the full SHA bf0095bView commit details -
While iterating over all the waiters, if we happen to remove a waiter, it would skip the next item on the next iteration because the indexes changed. So, I changed it to wait until after it finishes iterating over all the waiters in the array to remove them. I also changed it to use a 'for of' loop since there was no longer a reason to keep the index around.
Configuration menu - View commit details
-
Copy full SHA for 6816a6f - Browse repository at this point
Copy the full SHA 6816a6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d81e0d - Browse repository at this point
Copy the full SHA 1d81e0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f46147c - Browse repository at this point
Copy the full SHA f46147cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.