Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute: VM.waitFor() #2047

Merged
merged 11 commits into from
Apr 7, 2017
Merged

compute: VM.waitFor() #2047

merged 11 commits into from
Apr 7, 2017

Commits on Apr 7, 2017

  1. compute: VM.waitFor()

    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    1854a24 View commit details
    Browse the repository at this point in the history

  2. Fix linting errors

    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    6f2541f View commit details
    Browse the repository at this point in the history

  3. Fix coding style lint errors

    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    7531026 View commit details
    Browse the repository at this point in the history

  4. Fix options.timeout error 

    Previously, this would set the timeout to the default of 300 if the timeout was set to 0. Fixed so that it only checks to see if timeout is not set. 
Added JSdoc comments clarifying that if the options.timeout is set to 0, it will poll once and then timeout if the state is not reached.
    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    aafd09b View commit details
    Browse the repository at this point in the history

  5. Fix JSDocs comments 

    WAIT_FOR_POLLING_INTERVAL and VALD_STATUSES should be set to private.
    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    6cffe29 View commit details
    Browse the repository at this point in the history

  6. Fix error handling 

    An invalid status now throws an Error, since this is a problem with how the function is called (like detatchDisk() does)
A time out will return an Error in the callback , with the appropriate message, code, and name.
    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    15ce07b View commit details
    Browse the repository at this point in the history

  7. Fix errors in waitFor() documentation examples

    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    9aeead3 View commit details
    Browse the repository at this point in the history

  8. fix JSDocs code examples 

    There is no apiResponse passed to the callback.
    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    bf0095b View commit details
    Browse the repository at this point in the history

  9. Fix startPolling_ bug 

    While iterating over all the waiters, if we happen to remove a waiter, it would skip the next item on the next iteration because the indexes changed. So, I changed it to wait until after it finishes iterating over all the waiters in the array to remove them.

I also changed it to use a 'for of' loop since there was no longer a reason to keep the index around.
    @stephenplusplus
    Nick Zatkovich authored and stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    6816a6f View commit details
    Browse the repository at this point in the history

  10. add tests

    @stephenplusplus
    stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    1d81e0d View commit details
    Browse the repository at this point in the history

  11. remove includes() usage

    @stephenplusplus
    stephenplusplus committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    f46147c View commit details
    Browse the repository at this point in the history