-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bigquery: fix error callback arguments #737
Merged
stephenplusplus
merged 1 commit into
googleapis:master
from
callmehiphop:dataset-metadata-err
Jul 23, 2015
Merged
bigquery: fix error callback arguments #737
stephenplusplus
merged 1 commit into
googleapis:master
from
callmehiphop:dataset-metadata-err
Jul 23, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmehiphop
added
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
api: bigquery
Issues related to the BigQuery API.
labels
Jul 23, 2015
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jul 23, 2015
Good catch! Could you also show that the apiResponse comes back in the @example? |
Dataset#setMetadata was not passing the correct arguments in for request failures Updated setMetadata example to reflect callback arguments
@stephenplusplus done! |
stephenplusplus
added a commit
that referenced
this pull request
Jul 23, 2015
bigquery: fix error callback arguments
Thanks! |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
* chore(main): release 4.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the BigQuery API.
cla: yes
This human has signed the Contributor License Agreement.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataset#setMetadata
was not passing the correct arguments in for request failures