Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery: fix error callback arguments #737

Merged
merged 1 commit into from
Jul 23, 2015
Merged

bigquery: fix error callback arguments #737

merged 1 commit into from
Jul 23, 2015

Conversation

callmehiphop
Copy link
Contributor

Dataset#setMetadata was not passing the correct arguments in for request failures

@callmehiphop callmehiphop added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigquery Issues related to the BigQuery API. labels Jul 23, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2015
@stephenplusplus
Copy link
Contributor

Good catch! Could you also show that the apiResponse comes back in the @example?

Dataset#setMetadata was not passing the correct
arguments in for request failures

Updated setMetadata example to reflect callback arguments
@callmehiphop
Copy link
Contributor Author

@stephenplusplus done!

stephenplusplus added a commit that referenced this pull request Jul 23, 2015
bigquery: fix error callback arguments
@stephenplusplus stephenplusplus merged commit 5c7059b into googleapis:master Jul 23, 2015
@stephenplusplus
Copy link
Contributor

Thanks!

@callmehiphop callmehiphop deleted the dataset-metadata-err branch July 24, 2015 15:46
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Jan 10, 2023
* chore(main): release 4.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 24, 2023
sofisl pushed a commit that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants