core: use external modules #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Looks good 💃 |
stephenplusplus
force-pushed
the
spp--util-modularization
branch
from
c6ab33e
to
3ed39f2
Compare
callmehiphop
added a commit
that referenced
this pull request
Aug 3, 2015
core: use external modules
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
samples: pull in latest typeless bot, clean up some comments Source-Link: googleapis/synthtool@0a68e56 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 9, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
…andwritten libraries (#765) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's about time we incorporate the spirit of npm in our library; that is, small modules, preferring re-use over re-creation.
Todos
New modules used:
Sorry for the enormous PR, @callmehiphop.