Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google Compute Engine #792

Merged
merged 2 commits into from
Aug 21, 2015

Conversation

stephenplusplus
Copy link
Contributor

Continuing from #721

This PR puts a comb over the great work @mziccard gave us when he implemented support for Compute Engine. That includes various small documentation tweaks, code style things, unit tests, and system tests.

To Dos

  • Documentation
    • Callback parameters
    • Upstream API links (depends on docs: upstream links #790)
      • Check for misspellings of "@"resource or improper {"@"link} tags
      • Confirm using v1 and not latest
  • Tests
    • Unit
      • Address
      • Disk
      • Firewall
      • Index
      • Network
      • Operation
      • Region
      • Snapshot
      • VM
      • Zone
    • System

Changed since #721:

  • Added an operation.onComplete method. Credit to Marco for the idea -- we couldn't think of a way to implement it un-confusingly at the time, so I hope this is a good solution.
  • Removed all throwing where we were validating what the API expects. We typically let the API request go through and have its error clarify what was incorrect about the input. We only throw when our code cannot proceed.
  • Added sane defaults in zone.createVM. Explained here. That necessitated two new modules: gce-images and to handle auth the same as gcloud does, google-auto-auth (this one can eventually be used in gcloud directly).
  • Renamed Instance to VM: zone.createVM, zone.getVMs, etc.
  • Added compute.getZones() and compute.getRegions()

Docs preview: https://stephenplusplus.github.io/gcloud-node/#/docs/master/compute

@stephenplusplus stephenplusplus added the api: compute Issues related to the Compute Engine API. label Aug 12, 2015
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 12, 2015
## Google Compute Engine

- [API Documentation][gcloud-compute-docs]
- [Official Documentation][cloud-compute-docs]

This comment was marked as spam.

This comment was marked as spam.

@stephenplusplus stephenplusplus force-pushed the spp--compute branch 2 times, most recently from cee66d9 to 2b303b6 Compare August 13, 2015 19:18
@stephenplusplus
Copy link
Contributor Author

Anyone interested, check out the system tests for an actual working sample of code!

@stephenplusplus
Copy link
Contributor Author

@callmehiphop if you want to, take a look at the system tests (and the code) if you catch anything weird. It's about time to lock it down with unit tests.

Documentation will be a work in progress all the way up until the end.

@callmehiphop
Copy link
Contributor

Sweet, I'll run through those this afternoon :D

@stephenplusplus stephenplusplus force-pushed the spp--compute branch 4 times, most recently from 2f4b2fb to a47068e Compare August 18, 2015 19:04
@stephenplusplus
Copy link
Contributor Author

@stephenplusplus
Copy link
Contributor Author

@mziccard we're getting close! I plan to include two commits when the PR merges, your original one and then all of our tests and such smashed into one more on top of it. Our CI bot is asking that you give us some type of 👌

@mziccard
Copy link
Contributor

You have my permission to merge the commits :)

@stephenplusplus stephenplusplus removed the cla: no This human has *not* signed the Contributor License Agreement. label Aug 21, 2015
@stephenplusplus
Copy link
Contributor Author

Phew!

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 21, 2015
@stephenplusplus stephenplusplus removed cla: no This human has *not* signed the Contributor License Agreement. don't merge labels Aug 21, 2015
stephenplusplus added a commit that referenced this pull request Aug 21, 2015
@stephenplusplus stephenplusplus merged commit f10000f into googleapis:master Aug 21, 2015
@stephenplusplus
Copy link
Contributor Author

Thanks everyone! This is now one of my favorites :)

sofisl pushed a commit that referenced this pull request Nov 11, 2022
fix: remove resource_reference for invisible resources.
Committer: @sheimi
PiperOrigin-RevId: 362967283
Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Mar 15 10:09:15 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: a1ba4568e228b25124f9a6689cfe3bcab75498a6
Source-Link: googleapis/googleapis@a1ba456
fix: remove rpc or fields that are unintended to release
fix: remove StreamingAnalyzeContent, CreateCallMatcher, ListCallMatchers, DeleteCallMatcher rpc from v2/v2beta1
fix: remove `input_audio` field from AnalyzeContentRequest from v2/v2beta1
fix: remove proto message CreateCallMatcherRequest, CreateCallMatcherResponse, ListCallMatchersRequest, ListCallMatchersResponse, DeleteCallMatcherRequest, DeleteCallMatcherResponse, CallMatcher, StreamingAnalyzeContentRequest, StreamingAnalyzeContentResponse, AudioInput from v2/v2beta1, TelephonyDtmfEvents, TelephonyDtmf from v2
Committer: @sheimi
PiperOrigin-RevId: 363762006
Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Mar 18 15:37:05 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 8d17d8fafbb87ac64bb3179b99ac34ed41375a51
Source-Link: googleapis/googleapis@8d17d8f
fix: Remove resource_reference from UpdateAnswerRecord.
Committer: @sheimi
PiperOrigin-RevId: 363947872
Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Mar 19 12:36:25 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 5da78db589d423db6bcd6a35637c923fe1a7665c
Source-Link: googleapis/googleapis@5da78db
docs: fix link for version and environment in participant doc.
fix: Add all missing regional HTTP bindings in DF API.
PiperOrigin-RevId: 364356707
Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Mar 22 10:50:15 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 5ef92c3f11395a59f55ced317423b992e61d5cfe
Source-Link: googleapis/googleapis@5ef92c3
feat: expose MP3_64_KBPS and MULAW for output audio encodings.
PiperOrigin-RevId: 364696134
Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Mar 23 18:45:59 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c2bdbfa6f7423369da902a5faaa86bfd213b5169
Source-Link: googleapis/googleapis@c2bdbfa
feat: expose MP3_64_KBPS and MULAW for output audio encodings.
PiperOrigin-RevId: 364697203
Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Mar 23 18:52:05 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 80c3d0da03afdb09a194341087fe666743d694a0
Source-Link: googleapis/googleapis@80c3d0d
sofisl pushed a commit that referenced this pull request Jan 24, 2023
* feat: Add transcript normalization

Committer: @jameszhao
PiperOrigin-RevId: 391603958

Source-Link: googleapis/googleapis@76bed90

Source-Link: googleapis/googleapis-gen@c7aaaa7

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 24, 2023
sofisl pushed a commit that referenced this pull request Jan 25, 2023
* feat: Add transcript normalization

Committer: @jameszhao
PiperOrigin-RevId: 391603958

Source-Link: googleapis/googleapis@76bed90

Source-Link: googleapis/googleapis-gen@c7aaaa7

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 25, 2023
gcf-owl-bot bot added a commit that referenced this pull request Apr 6, 2023
Note: manually updated proto file, but it yields the same result of the new disco-converter would generate.

Fixes: googleapis/google-cloud-go#7345
Source-Link: googleapis/googleapis@59828ba

Source-Link: googleapis/googleapis-gen@2649582
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjI2NDk1ODI1N2M1MzUyZGIwYmM5MTBjMDBmMTQ3YjgyMWIwMTA2MzYifQ==
danieljbruce added a commit that referenced this pull request Apr 12, 2023
* chore: add Go build targets for compute (#792)

Note: manually updated proto file, but it yields the same result of the new disco-converter would generate.

Fixes: googleapis/google-cloud-go#7345
Source-Link: googleapis/googleapis@59828ba

Source-Link: googleapis/googleapis-gen@2649582
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjI2NDk1ODI1N2M1MzUyZGIwYmM5MTBjMDBmMTQ3YjgyMWIwMTA2MzYifQ==

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Sep 13, 2023
* chore(main): release 4.0.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants