storage: do not fail transfers where validation is skipped #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
type: bug
googlebot
added
the
cla: yes
callmehiphop
added a commit
that referenced
this pull request
Sep 24, 2015
storage: do not fail transfers where validation is skipped
|
👍 |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
…ic of the streaming APIs (#892) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 405426307 Source-Link: googleapis/googleapis@a51c341 Source-Link: googleapis/googleapis-gen@c59fe82 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzU5ZmU4MmVlMDU5NzQwMGI2OWJkZDE5M2IzYjJlMTVlMTNlYjlkMCJ9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #889
Instead of assuming a data integrity failure in all cases, we only assume a failure if the user wanted data integrity checks in the first place.
Definitely should give a patch release for this.