Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [BigQueryStorage] update client libraries to support Database operations #4963

Closed
wants to merge 2 commits into from
Closed

feat: [BigQueryStorage] update client libraries to support Database operations #4963

wants to merge 2 commits into from

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 5, 2022 •
edited by bshaffer
Loading

  • Regenerate this pull request now.

PiperOrigin-RevId: 419710013

Source-Link: googleapis/googleapis@b7c9d05

Source-Link: https://github.com/googleapis/googleapis-gen/commit/ae498279c4e71cd4aa6e0655e92a693df97472c4
Copy-Tag: eyJwIjoiQmlnUXVlcnlTdG9yYWdlLy5Pd2xCb3QueWFtbCIsImgiOiJhZTQ5ODI3OWM0ZTcxY2Q0YWE2ZTA2NTVlOTJhNjkzZGY5NzQ3MmM0In0=

@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners January 5, 2022 08:52
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2022
@bshaffer bshaffer changed the title feat: update client libraries to support Database operations feat: [BigQueryStorage] update client libraries to support Database operations Jan 7, 2022
@bshaffer
Copy link
Contributor

Debugging this, I found reverting the metadata/ files fixed the tests.

@bshaffer bshaffer mentioned this pull request Jan 25, 2022
Closed
1 task
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Jan 31, 2022

Owl bot is regenerating pull request 4963...
Build name: NDlmMjRiMTMtNDAyYS00NDc5LTkyOWQtZDg5MjdmMWJkNTk2

@gcf-owl-bot
feat: update client libraries to support Database operations
404ba05 
PiperOrigin-RevId: 419710013

Source-Link: googleapis/googleapis@b7c9d05

Source-Link: googleapis/googleapis-gen@ae49827
Copy-Tag: eyJwIjoiQmlnUXVlcnlTdG9yYWdlLy5Pd2xCb3QueWFtbCIsImgiOiJhZTQ5ODI3OWM0ZTcxY2Q0YWE2ZTA2NTVlOTJhNjkzZGY5NzQ3MmM0In0=
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-a34f59bb-839d-4c61-b44e-4216634e599f branch from 0b03937 to 404ba05 Compare January 31, 2022 15:08
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 31, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 31, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2022
@dwsupplee
Copy link
Contributor

I've traced down the error message we're getting in our test suite to an issue in protobuf, which I have opened a PR for: protocolbuffers/protobuf#9462

Resolving the issue on a local copy of protobuf reaveals the following error:

proto not added: google.protobuf.DescriptorProto for google.cloud.bigquery.storage.v1.ProtoSchema

After debugging, the holdup occurs while cross linking messages from descriptor.proto: https://github.com/googleapis/googleapis/blob/master/google/cloud/bigquery/storage/v1/protobuf.proto#L39

Digging in further, I discovered the following: https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/compiler/php/php_generator.cc#L981-L983

// Currently, descriptor.proto is not ready for external usage. Skip to
// import it for now, so that its dependencies can still work as long as
// they don't use protos defined in descriptor.proto.

My current understanding is this is being skipped because descriptor.proto is still using the proto2 syntax, which the official library does not support.

Working on next steps we can take to unblock this.

@dwsupplee dwsupplee closed this May 16, 2022
@dwsupplee dwsupplee mentioned this pull request May 18, 2022
Merged
1 task
@bshaffer bshaffer deleted the owl-bot-a34f59bb-839d-4c61-b44e-4216634e599f branch December 2, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshaffer @dwsupplee @kokoro-team