Skip to content

Commit

Permalink
Replace redundant 'job done' assertion with a note.
Browse files Browse the repository at this point in the history
Explain why we can't make any real assertions about the status of the
cancelled job.

Addresses:
#2379 (comment).
  • Loading branch information
tseaver committed Sep 21, 2016
1 parent b3f130a commit 14b8cc4
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion system_tests/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -464,4 +464,8 @@ def _job_done(instance):
retry = RetryInstanceState(_job_done, max_tries=8)
retry(job.reload)()

self.assertEqual(job.state.lower(), 'done')
# The `cancel` API doesn't leave any reliable traces on
# the status of the job resource, so we can't really assert for
# them here. The best we can do is not that the API call didn't
# raise an error, and that the job completed (in the `retry()`
# above).

0 comments on commit 14b8cc4

Please sign in to comment.