Skip to content

Commit

Permalink
Addressing review feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
dhermes committed Apr 22, 2016
1 parent 4b69437 commit 1792d20
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion gcloud/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class InternalServerError(ServerError):
code = 500


class NotImplementedMethod(ServerError):
class MethodNotImplemented(ServerError):
"""Exception mapping a '501 Not Implemented' response."""
code = 501

Expand Down
6 changes: 3 additions & 3 deletions gcloud/search/document.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,9 @@ def _parse_value_resource(resource):
return TimestampValue(value)
if 'geoValue' in resource:
lat_long = resource['geoValue']
lat, long_val = [float(coord.strip())
for coord in lat_long.split(',')]
return GeoValue((lat, long_val))
latitude, longitude = [float(coord.strip())
for coord in lat_long.split(',')]
return GeoValue((latitude, longitude))
raise ValueError("Unknown value type")

def _parse_fields_resource(self, resource):
Expand Down

0 comments on commit 1792d20

Please sign in to comment.