Close the to_dataframe progress bar when finished. (#7757)

googleapis · Apr 22, 2019 · 3e06961 · 3e06961
1 parent ee804a1
commit 3e06961
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/bigquery/google/cloud/bigquery/table.py b/bigquery/google/cloud/bigquery/table.py
@@ -1385,6 +1385,10 @@ def _to_dataframe_tabledata_list(self, dtypes, progress_bar=None):
                 progress_bar.total = progress_bar.total or self.total_rows
                 progress_bar.update(len(current_frame))
 
+        if progress_bar is not None:
+            # Indicate that the download has finished.
+            progress_bar.close()
+
         return pandas.concat(frames)
 
     def _to_dataframe_bqstorage_stream(

diff --git a/bigquery/tests/unit/test_table.py b/bigquery/tests/unit/test_table.py
@@ -1503,6 +1503,7 @@ def test_to_dataframe_progress_bar(
 
             progress_bar_mock.assert_called()
             progress_bar_mock().update.assert_called()
+            progress_bar_mock().close.assert_called_once()
             self.assertEqual(len(df), 4)
 
     @unittest.skipIf(pandas is None, "Requires `pandas`")