Skip to content

Commit

Permalink
Addressing review comments.
Browse files Browse the repository at this point in the history
- Removing accidentally including bigquery module from
  IGNORED_MODULES in verify_include_modules
- Adding Sphinx as a lint dependency (it couldn't be imported)
- Fixing Python 2 style print statements in run_pylint
  • Loading branch information
dhermes committed Jan 28, 2016
1 parent aafe3d1 commit c04d18d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions scripts/run_pylint.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,12 @@ def get_files_for_linting(allow_limited=True):
if diff_base is not None and allow_limited:
result = subprocess.check_output(['git', 'diff', '--name-only',
diff_base])
print 'Using files changed relative to %s:' % (diff_base,)
print '-' * 60
print result.rstrip('\n') # Don't print trailing newlines.
print '-' * 60
print('Using files changed relative to %s:' % (diff_base,))
print('-' * 60)
print(result.rstrip('\n')) # Don't print trailing newlines.
print('-' * 60)
else:
print 'Diff base not specified, listing all files in repository.'
print('Diff base not specified, listing all files in repository.')
result = subprocess.check_output(['git', 'ls-files'])

return result.rstrip('\n').split('\n'), diff_base
Expand Down Expand Up @@ -217,7 +217,7 @@ def lint_fileset(filenames, rcfile, description):
print(error_message, file=sys.stderr)
sys.exit(status_code)
else:
print 'Skipping %s, no files to lint.' % (description,)
print('Skipping %s, no files to lint.' % (description,))


def main():
Expand Down
1 change: 0 additions & 1 deletion scripts/verify_included_modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
OBJECT_INVENTORY_RELPATH = os.path.join('_build', 'html', 'objects.inv')
IGNORED_PREFIXES = ('test_', '_')
IGNORED_MODULES = frozenset([
'gcloud.bigquery.query',
'gcloud.bigtable.client',
'gcloud.bigtable.cluster',
'gcloud.bigtable.column_family',
Expand Down
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ deps =
pylint
unittest2
psutil
Sphinx
passenv = {[testenv:system-tests]passenv}

[testenv:system-tests]
Expand Down

0 comments on commit c04d18d

Please sign in to comment.