Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gcloud_bigtable as gcloud.bigtable #1212

Closed
2 tasks
jgeewax opened this issue Nov 3, 2015 · 13 comments
Closed
2 tasks

Merge gcloud_bigtable as gcloud.bigtable #1212

jgeewax opened this issue Nov 3, 2015 · 13 comments
Assignees
Labels
api: bigtable Issues related to the Bigtable API.

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Nov 3, 2015

/cc @dhermes

Ideally, the way this would work is:

$ pip install gcloud  # This should work even if I don't have gRPC
$ python
>>> from gcloud import bigtable
Exception: Bigtable requires that you have gRPC installed.
  Follow the instructions here: http://github.com/GoogleCloudPlatform/gcloud-python/docs/install-grpc.md

Instructions would say something like:

First, install gRPC core.

  • For Debian, ...
  • For Ubuntu, ...
  • For Mac, ...
  • For Windows, ...
  • For some other OS, ...

After that, you need the Python gRPC package:

$ pip install grpc

Once that's done, you should be able to run from gcloud import bigtable :)

If you're still having problems, try running python -m gcloud.check_grpc to diagnose the issue.

The check_grpc script would give us info on the user's set-up so we can help figure out what's broken...

$ pip install gcloud
$ python -m gcloud.check_grpc
Python: [details about Python]
Platform: [some details about the platform]
gcloud-python: [...]
libssl: [...]
gRPC core: [...]
gRPC Python package: [...]

Stuff we still need to do:

  • Write gRPC installation instructions (or include ones from the gRPC repo) specific to gcloud-python
  • Travis needs to be able to run our system tests (requires gRPC on the test server)
@jgeewax jgeewax added the api: bigtable Issues related to the Bigtable API. label Nov 3, 2015
@dhermes
Copy link
Contributor

dhermes commented Nov 3, 2015

@jgeewax Did you forget about the discussion about this in #1159?

@jgeewax
Copy link
Contributor Author

jgeewax commented Nov 3, 2015

Totally related, however the goal hasn't changed, right?

$ sudo apt-get install grpcio
$ pip install gcloud grpc
$ python
>>> from gcloud import bigtable
>>> # Happiness

The layout of the distribution (#1159) is the implementation detail, right?

@dhermes
Copy link
Contributor

dhermes commented Nov 3, 2015

True that. Good call. Thanks for bringing me back down to earth. We really should revive the conversation in #1159.

@jgeewax
Copy link
Contributor Author

jgeewax commented Nov 4, 2015

It sounds to me that resolving #1159 is a big task, and not something we can do all that quickly, however we have some folks really pushing to make gcloud-python look (somewhat) like how this issue describes it before the end of the year.

@dhermes : Can you help me understand:

  1. What happens if we do Split out APIs into separately-installable distributions? #1159 later, and focus on this issue for today
  2. What steps we need to do to accomplish this issue (without doing Split out APIs into separately-installable distributions? #1159)

@dhermes
Copy link
Contributor

dhermes commented Nov 8, 2015

We can totally do #1159 later and merge it in now (it still needs to be reviewed somewhere). Still have #1154 in flux ready to continue the merge in if we decide to go that route.

@dhermes
Copy link
Contributor

dhermes commented Nov 17, 2015

This is in progress now

@jgeewax
Copy link
Contributor Author

jgeewax commented Feb 17, 2016

Just FYI, I'm seeing the following installation work on Ubuntu, haven't tested on Mac yet:

$ sudo apt-get install -y python-pip
$ sudo pip install -U six
$ sudo pip install https://testpypi.python.org/packages/source/g/grpcio/grpcio-0.13.0rc2.tar.gz#md5=40bb88e3184dc4fba0da6939d8756041

It's a pre-release, but if we can call it "good" then this means we can add gRPC as a dependency, right?

@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2016

Once it's on PyPI, I'd say yes (but haven't verified).

@dhermes
Copy link
Contributor

dhermes commented Feb 19, 2016

I just installed it but haven't verified it works yet (the 0.13 code is different from the beta code which was different from the alpha code).

@vinays
Copy link

vinays commented Feb 24, 2016

@dhermes do you have a rough estimate of when will gcloud upgrade to grpcio==0.13 ? Is there an open issue for it that I can subscribe?

@dhermes
Copy link
Contributor

dhermes commented Feb 24, 2016

Will take another stab at it today. I tried before and was stymied by the fact that the grpc_python_plugin is not install-able anywhere. Building from source isn't too bad for a one-off though.

@dhermes
Copy link
Contributor

dhermes commented Feb 25, 2016

@vinays FYI #1532 is out.

@dhermes
Copy link
Contributor

dhermes commented Feb 29, 2016

The merge is done, everything from here is just clean-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

No branches or pull requests

3 participants