Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding gRPC stubs to Bigtable clients #1154

Merged
merged 3 commits into from
Nov 17, 2015
Merged

Adding gRPC stubs to Bigtable clients #1154

merged 3 commits into from
Nov 17, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 24, 2015

NOTE: Uses #1153 as diffbase

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Sep 24, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2015
@dhermes dhermes force-pushed the grpc-stubs-in-client branch 2 times, most recently from e33fe3d to 3e97689 Compare September 29, 2015 20:28
@dhermes
Copy link
Contributor Author

dhermes commented Sep 29, 2015

@tseaver Rebased on top of `master. PTAL.

dhermes
dhermes reviewed Sep 29, 2015
View reviewed changes
setup.py
@@ -15,7 +15,7 @@
'google-apitools',
'httplib2 >= 0.9.1',
'oauth2client >= 1.4.6',
'protobuf == 3.0.0-alpha-1',
'protobuf >= 3.0.0a3',

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor Author

dhermes commented Oct 1, 2015

@tseaver PTAL. (So you can at least get a feel for how stubs are created and how they work.)

@dhermes
Copy link
Contributor Author

dhermes commented Oct 14, 2015

@tseaver We should either get this in or move forward with the sub-package discussion in #1159

Letting both languish is no bueno

@tseaver
Copy link
Contributor

tseaver commented Oct 14, 2015

What would be smoothest? I dropped off reviewing this one because it seemed like #1159 was the Right Thing(TM) for dealing with the wonky gRPC dependency. I can go ahead an review here, with the notion that we will split out the per-API projects later.

@dhermes
Copy link
Contributor Author

dhermes commented Oct 15, 2015

I think #1159 would be smoothest. If we decide NOT to split out into sub-packages then we can revive this.

@dhermes dhermes mentioned this pull request Nov 8, 2015
Closed
2 tasks
@dhermes
Copy link
Contributor Author

dhermes commented Nov 15, 2015

@tseaver Can we resume review of this per #1212?

tseaver
tseaver reviewed Nov 16, 2015
View reviewed changes
gcloud/bigtable/client.py
from gcloud.client import _ClientFactoryMixin
from gcloud.client import _ClientProjectMixin
from gcloud.credentials import get_credentials


TABLE_STUB_FACTORY = (bigtable_table_service_pb2.
early_adopter_create_BigtableTableService_stub)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Add stubs to Bigtable Client class.
a6320af 
For now, just adding custom getters which will tell users
whether the Client has been started. Commit to add
methods to actually make the stubs and start the Client will
be forthcoming.
@dhermes
Adding ability to start/stop clients.
32c4c95 
This creates gRPC stubs for talking to each Bigtable
service needed by the client.
@dhermes
Adding comment about gRPC stubs context managers.
9cd7022 
In particular, explaining why we __enter__ them but
have no corresponding __enter__ for our users.
@dhermes
Copy link
Contributor Author

dhermes commented Nov 16, 2015

@tseaver PTAL. I added a comment in the 3rd commit.

@tseaver
Copy link
Contributor

tseaver commented Nov 17, 2015

LGTM.

dhermes added a commit that referenced this pull request Nov 17, 2015
@dhermes
Merge pull request #1154 from dhermes/grpc-stubs-in-client
5d589a1 
Adding gRPC stubs to Bigtable clients
@dhermes dhermes merged commit 5d589a1 into googleapis:master Nov 17, 2015
@dhermes dhermes deleted the grpc-stubs-in-client branch November 17, 2015 01:35
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot