Int64 CheckValue in datastore.helpers returns None instead of the value.

[jgeewax]

We current do "return INT64(val)", however INT64 returns nothing. We need to run this method, and then return the value.

See: https://code.google.com/p/protobuf/source/browse/trunk/python/google/protobuf/internal/type_checkers.py?r=163#100 returns None. We need to check and then return "val".

and

https://github.com/GoogleCloudPlatform/gcloud-python/blob/1779aeccdea1f2557e5e2cf80e448d0b64f48527/gcloud/datastore/helpers.py#L59

[tseaver]

Hmm, the code I have (and which the tests exercise) does return the value:

class IntValueChecker(object):

  """Checker used for integer fields.  Performs type-check and range check."""

  def CheckValue(self, proposed_value):
    if not isinstance(proposed_value, (int, long)):
      message = ('%.1024r has type %s, but expected one of: %s' %
                 (proposed_value, type(proposed_value), (int, long)))
      raise TypeError(message)
    if not self._MIN <= proposed_value <= self._MAX:
      raise ValueError('Value out of range: %d' % proposed_value)
    # We force 32-bit values to int and 64-bit values to long to make
    # alternate implementations where the distinction is more significant
    # (e.g. the C++ implementation) simpler.
    proposed_value = self._TYPE(proposed_value)
    return proposed_value

The version installed is 'protobuf-2.6.0'. Your URL pins the view at r163, but the trunk (which corresponds to 2.6.0, as well) is at r551:
https://code.google.com/p/protobuf/source/browse/trunk/python/google/protobuf/internal/type_checkers.py?r=551#124

[tseaver]

r551, which added the bits making type checkers return a possibly-coerced value, landed 2014-08-12, and is included only in protobuf 2.6.0.

https://code.google.com/p/protobuf/source/detail?r=551

So, unless we want topin our requirement to 'protobuf >= 2.6.0', I guess we need to apply @jgeewax's patch in order to degrade gracefully against earlier versions.

[dhermes]

I think the approach that will result in the least headache is

• Pin on protobuf==2.5.0 until the dateutil issue is fixed. (@jgeewax that will need to go in Fix #215: Helper for int and double now work as expected. #216)
• Push Fix #215: Helper for int and double now work as expected. #216 through with the 2.5.0 dependence
• Open an issue and make a calendar reminder to check for a fix in google-apputils / a version 2.6.1 or 2.7.0 of protobuf at a later date
• (Optional) Subscribe to the issue
• (Optional) Someone bother the maintainers that have introduced the flaky dateutils requirements (i.e. >=1.4 and <2 in serial)