[documentation] inconsistent keyword argument for Key.from_path

[ghost]

documentation uses "dataset_id" whereas in the source code it takes a Dataset object with keyword "dataset"

[dhermes]

Thanks for reporting.

Can you point out what part of the documentation?

[ghost]

https://googlecloudplatform.github.io/gcloud-python/datastore-keys.html

On Sun Nov 30 2014 at 4:29:20 PM Danny Hermes notifications@github.com
wrote:

Thanks for reporting.

Can you point out what part of the documentation?

—
Reply to this email directly or view it on GitHub
#397 (comment)
.

[ghost]

My mistake, it appears to have been fixed since I first saw it (and
accidentally reported it on buganizer)

On Sun Nov 30 2014 at 4:40:16 PM Eli Bixby elibixby@google.com wrote:

https://googlecloudplatform.github.io/gcloud-python/datastore-keys.html

On Sun Nov 30 2014 at 4:29:20 PM Danny Hermes notifications@github.com
wrote:

Thanks for reporting.

Can you point out what part of the documentation?

—
Reply to this email directly or view it on GitHub
#397 (comment)
.

[dhermes]

So, to clarify, you're saying the params description is incorrect?

Anything else I'm missing? (We'll get this fixed ASAP.)

I think it may be useful to have an automated checker that params actually match the signature:
http://www.bytebucket.org/logilab/pylint/pull-request/143/new-extensions-directory-new-optional/diff
and have mentioned it before.

[ghost]

I was using the documentation which has disappeared (on cloud.google.com I think?), which had this mistake. Present documentation does not say anything about Key.from_path the class method. Which uses dataset rather than dataset_id. The constructor does use dataset_id as listed, and is obviously the preferred method of instantiation).

EDIT: since I can't seem to find the offending documentation anymore, probably fine to close this.
EDIT2: was definitely originating from version issues. Sorry for the noise.