Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler needs to shutdown in a way compatible with SimpleQueue and Queue types for worker queue. #5292

Closed
crwilcox opened this issue May 3, 2018 · 0 comments
Closed

Scheduler needs to shutdown in a way compatible with SimpleQueue and Queue types for worker queue. #5292

crwilcox opened this issue May 3, 2018 · 0 comments
Assignees
@crwilcox

Comments

@crwilcox
Copy link
Contributor

crwilcox commented May 3, 2018

Currently one test is failing for the scheduler. The issue is Py3.7 changed the _worker_queue to be a SimpleQueue.

Traceback (most recent call last):
File "/Users/crwilcox/workspace/google-cloud-python/pubsub/tests/unit/pubsub_v1/subscriber/test_scheduler.py", line 51, in test_schedule
scheduler_.shutdown()
File "/Users/crwilcox/workspace/google-cloud-python/pubsub/google/cloud/pubsub_v1/subscriber/scheduler.py", line 121, in shutdown
self._executor._work_queue.
AttributeError: '_queue.SimpleQueue' object has no attribute 'queue'
@crwilcox crwilcox mentioned this issue May 3, 2018
Merged
@crwilcox crwilcox self-assigned this May 4, 2018
crwilcox added a commit to crwilcox/google-cloud-python that referenced this issue May 4, 2018
@crwilcox
Fix googleapis#5292 by draining queue in a way compatible with Simple…
8fe5f55 
…Queue and Queue
atulep pushed a commit that referenced this issue Apr 3, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
cddc37b 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
atulep pushed a commit that referenced this issue Apr 18, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
ee130ea 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Jun 4, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
57002c6 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Jun 4, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
fef06cb 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Jul 6, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
ac2eee4 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Sep 22, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
6311be8 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Sep 22, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
03f7ef6 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Sep 22, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
a7830f4 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Sep 22, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
600638a 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Sep 22, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
83f633b 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Sep 22, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
8e6a031 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Oct 21, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
6d5c710 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Oct 21, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
4a3bfd9 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Oct 21, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
a66fd7d 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Oct 22, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
2a9cfd8 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Oct 22, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
cb20611 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this issue Oct 31, 2023
@crwilcox
Add Test runs for Python 3.7 and remove 3.4 (#5295)
6877b31 
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crwilcox crwilcox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crwilcox