Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] higher precision timestamps #6547

Closed
crwilcox opened this issue Nov 16, 2018 · 1 comment
Closed

[Firestore] higher precision timestamps #6547

crwilcox opened this issue Nov 16, 2018 · 1 comment
Assignees
@tseaver
Labels
api: firestore Issues related to the Firestore API. triaged for GA type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

The Python SDK timestamps are lossy. The SDK doesn’t expose a way to retrieve timestamps with higher precision.
@crwilcox crwilcox added api: firestore Issues related to the Firestore API. triaged for GA labels Nov 16, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 16, 2018

I'm not sure what this item addresses. We expose the timestamp_pb2.Timestamp fields, which are full nanosecond precision.

For user-set values (versus the DocumentSnapshot attributes I linked), we have the google.api_core.datetime_helpers.DateTimeWithNanos subclass of the stdlib's datetime.datetime, but no conversion utilities between it and timestamp_pb2.Timestamp.

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Nov 17, 2018
@tseaver tseaver added the type: process A process-related concern. May include testing, release, or the like. label Nov 19, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Nov 19, 2018
This was referenced Dec 13, 2018
Merged
Merged
tseaver added a commit that referenced this issue Dec 13, 2018
@tseaver
Api_core: Convert 'DatetimeWithNanos' to / from 'google.protobuf.time…
df51357 
…stamp_pb2.Timestamp' (#6919)

Toward #6547.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the Firestore API. triaged for GA type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tseaver @JustinBeckwith @crwilcox