Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bigquery): update code samples of load table autodetect and truncate #10176

Closed
wants to merge 3 commits into from
Closed

refactor(bigquery): update code samples of load table autodetect and truncate #10176

wants to merge 3 commits into from

Conversation

HemangChothani
Copy link
Contributor

Towards #8989

List of changes:

  1. load_table_uri_autodetect_csv
  2. load_table_uri_autodetect_json
  3. load_table_uri_truncate_avro.py
  4. load_table_uri_truncate_json.py
  5. load_table_uri_truncate_csv.py
  6. load_table_uri_truncate_orc.py
  7. load_table_uri_truncate_parquet.py

@HemangChothani HemangChothani requested review from tswast and a team January 21, 2020 12:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2020
@plamut
Copy link
Contributor

plamut commented Jan 23, 2020

(not a complete review in any way, just a remark)

Shouldn't the copyright notice contain the year 2020 in new files?

@HemangChothani
Copy link
Contributor Author

HemangChothani commented Jan 24, 2020 •
edited
Loading

test_client_load_partitioned_table snippet failed is unrelated to changes.

@plamut plamut mentioned this pull request Jan 24, 2020
Merged
@plamut
Copy link
Contributor

plamut commented Jan 24, 2020

The failing snippet test is fixed in #10195.

@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Jan 31, 2020
@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 3, 2020
@plamut
Copy link
Contributor

plamut commented Feb 3, 2020

Starting the repo split, please do not merge.

@plamut
Copy link
Contributor

plamut commented Feb 6, 2020

The repo split for BigQuery is done, please re-open the PR in the new repo, thanks!

https://github.com/googleapis/python-bigquery

@plamut
Copy link
Contributor

plamut commented Feb 10, 2020

Superseded by googleapis/python-bigquery#28

@plamut plamut closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HemangChothani @plamut @googlebot @yoshi-kokoro