Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting external links in toctree. #1041

Merged
merged 1 commit into from
Aug 13, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 6, 2015

This is to bring the readthedocs version and custom layout closer together. (Maybe they can converge?)

Before:

screen_shot_005

After:

screen_shot_004

This is to bring the readthedocs version and custom layout
closer together. (Maybe they can converge?)
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Aug 6, 2015

Vs. RTD version

Before:

screen_shot_007

After:

screen_shot_006

@dhermes dhermes added the docs label Aug 6, 2015
@tseaver
Copy link
Contributor

tseaver commented Aug 6, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Aug 6, 2015

@jgeewax WDYT of this change?

@dhermes
Copy link
Contributor Author

dhermes commented Aug 12, 2015

@jgeewax Bump

@jgeewax
Copy link
Contributor

jgeewax commented Aug 13, 2015

LGTM @dhermes

dhermes added a commit that referenced this pull request Aug 13, 2015
@dhermes dhermes merged commit 04888d3 into googleapis:master Aug 13, 2015
@dhermes dhermes deleted the putting-external-links-in-toc branch August 13, 2015 19:45
@dhermes
Copy link
Contributor Author

dhermes commented Aug 13, 2015

@tseaver You mentioned before that Pyramid had a custom theme. I'd like to discuss a bit more as our two docsets get closer and closer to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants