Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused CSS and normalizing indents in docs/conf.py. #1043

Merged
merged 1 commit into from
Aug 19, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 7, 2015

@stephenplusplus Can you (or another from node side) confirm what github.min.css was used for?

@dhermes dhermes added the docs label Aug 7, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Aug 18, 2015

@stephenplusplus or @ryanseys Can you confirm what github.min.css was used for? (Our template was forked from yours by @silvolu)

@ryanseys
Copy link

Looks to me like it was used for syntax highlighting in our docs. I'm assuming it followed the color scheme of GitHub syntax highlighting, hence the name github.min.css. I didn't actually add the file so I'm not sure whether it was ever used / to what extent it was used.

@ryanseys
Copy link

@stephenplusplus
Copy link

Sorry for letting this one slip off my radar @dhermes. Ryan's right, it sets the theme of the highlight.js code blocks to match GitHub's color scheme. If you're not using highlightjs in your docs, then it's safe to remove.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 18, 2015

No worries. Thanks for the info!

@tseaver WDYT?

@tseaver
Copy link
Contributor

tseaver commented Aug 19, 2015

LGTM

dhermes added a commit that referenced this pull request Aug 19, 2015
Removing unused CSS and normalizing indents in docs/conf.py.
@dhermes dhermes merged commit 0e7eb45 into googleapis:master Aug 19, 2015
@dhermes dhermes deleted the normalizing-docs-conf branch August 19, 2015 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants