#1054: Set query cursor to 'None' when returned as empty string. #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -418,7 +418,10 @@ def next_page(self): | |||
| # for discussion. | |||
| entity_pbs, cursor_as_bytes, more_results_enum = query_results[:3] | |||
|
|
|||
| self._start_cursor = base64.b64encode(cursor_as_bytes) | |||
| if cursor_as_bytes == b'': | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM but I'm still not sure if |
tseaver
added a commit
that referenced
this pull request
Aug 12, 2015
#1054: Set query cursor to 'None' when returned as empty string.
|
@tseaver I was hoping we could discuss my concern before merging. Should I have held off the LGTM to make it clearer? |
|
Sorry -- I did take the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1054.