Modify gcloud-java logo to be white svg #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Yea -- w/o a screen shot I can't really say anything more than "hey nice XML!" |
|
@ajkannan Can you build the docs or do you need me to? |
|
I can build the docs & post the screenshot. |
|
Actually I'm getting some sphinx errors that have to do with how I setup and changed my environment. If it's not too much trouble, do you mind building them @dhermes ? |
|
I don't mind at all. I'd love to see the errors too (in case it's something we can fix / make easier) |
|
For future me and other people, here is how I am recreating this PR: $ # Visit: https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/1107/commits
$ # parent in MASTER: 0dfe5ebc936c141e8f3ca13733b69f68155fe76f
$ git branch pr-1107 0dfe5ebc936c141e8f3ca13733b69f68155fe76f
$ git checkout pr-1107
$ wget https://patch-diff.githubusercontent.com/raw/GoogleCloudPlatform/gcloud-python/pull/1107.patch
$ git am 1107.patch
$ rm 1107.patch
|
|
@jgeewax I'm going to merge. LMK if I missed something that needs to be reverted. |
dhermes
added a commit
that referenced
this pull request
Aug 27, 2015
Modify gcloud-java logo to be white svg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logo was a png with some extra color. This one is more in line with the style of the other language icons.