Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change order of arguments in mock http.request. #1119

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Change order of arguments in mock http.request. #1119

merged 1 commit into from
Aug 31, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 31, 2015

Noticed this while documenting the httplib2.Http.request() interface and our use of it

@dhermes
Change order of arguments in mock http.request.
34465f0 
Noticed this while documenting the httplib2.Http.request()
interface and our use of it
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2015
@tseaver
Copy link
Contributor

tseaver commented Aug 31, 2015

LGTM

dhermes added a commit that referenced this pull request Aug 31, 2015
@dhermes
Merge pull request #1119 from dhermes/change-http-request-input-order
f393318 
Change order of arguments in mock http.request.
@dhermes dhermes merged commit f393318 into googleapis:master Aug 31, 2015
@dhermes dhermes deleted the change-http-request-input-order branch August 31, 2015 20:32
@dhermes dhermes mentioned this pull request Sep 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot