Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for synchronous queries #1135

Merged
merged 11 commits into from
Sep 18, 2015
Merged

Add support for synchronous queries #1135

merged 11 commits into from
Sep 18, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 11, 2015

No description provided.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Sep 11, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2015
dhermes
dhermes reviewed Sep 17, 2015
View reviewed changes
gcloud/bigquery/job.py

class _SyncQueryConfiguration(object):
"""User-settable configuration options for synchronous query jobs."""
# None -> use server default.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Sep 17, 2015

Not sure why these lint failures didn't show up earlier:

gcloud/bigquery/job.py:412:1: W293 blank line contains whitespace
gcloud/bigquery/job.py:636:1: W293 blank line contains whitespace
gcloud/bigquery/job.py:715:1: W293 blank line contains whitespace
gcloud/bigquery/job.py:807:1: W293 blank line contains whitespace
gcloud/bigquery/job.py:946:1: W293 blank line contains whitespace

@tseaver
Copy link
Contributor Author

tseaver commented Sep 18, 2015

The stray whitespace was added in 7e5f645. Removed in ff565d3.

@tseaver
Copy link
Contributor Author

tseaver commented Sep 18, 2015

@dhermes PTAL

@dhermes
Copy link
Contributor

dhermes commented Sep 18, 2015

LGTM

tseaver added a commit that referenced this pull request Sep 18, 2015
@tseaver
Merge pull request #1135 from tseaver/bigquery-synchronous_queries
072990d 
Add support for synchronous queries
@tseaver tseaver merged commit 072990d into googleapis:master Sep 18, 2015
@tseaver tseaver deleted the bigquery-synchronous_queries branch September 18, 2015 15:57
@dhermes dhermes mentioned this pull request Sep 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot