-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bigtable generated files #1152
Add bigtable generated files #1152
Conversation
Many auxiliary files (i.e. not part of the Bigtable service definitions) are required.
I don't think there is much to review here: should we maybe be reviewing the generator first? |
Sure. That is contingent on whether we should add it to the repo. A |
Should we be checking in the |
Yeah good call! |
I think checking in the |
These were from https://github.com/GoogleCloudPlatform/cloud-bigtable-client/ as of commit ac69011db6396e0f47200d7e3691c903a9a692a2.
I just added the Do you want me to re-arrange the commits to make it more clear what's going in? |
Commit order doesn't really matter to me -- I'm going to look primarily at the |
When the |
Not unless you also have the |
@tseaver PTAL (I added the |
LGTM -- I wish we had directions (in |
Take a look through https://github.com/dhermes/gcloud-python-bigtable/blob/master/README.md and let me know what you'd like to be brought over. Unfortunately (or maybe it's fortunate?) the gRPC install story is ever-evolving so the docs will be out-of-date pretty soon. |
@tseaver These are generated with
https://github.com/dhermes/gcloud-python-bigtable/blob/7c88583a4f772701228c2c94c32a847670fe6a52/Makefile
I had to modify
https://github.com/dhermes/gcloud-python-bigtable/blob/7c88583a4f772701228c2c94c32a847670fe6a52/scripts/rewrite_imports.py
so that it rewrote imports as
gcloud.bigtable
instead ofgcloud_bigtable
.Should I try to port the
Makefile
over as well? The reason I hesitate is because it requires having a valid gRPC install.