Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope used for Cloud Search. #1183

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Fix scope used for Cloud Search. #1183

merged 1 commit into from
Oct 15, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 14, 2015

No description provided.

@tseaver tseaver added the search label Oct 14, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2015
@tseaver tseaver mentioned this pull request Oct 14, 2015
Closed
@dhermes
Copy link
Contributor

dhermes commented Oct 14, 2015

Docs?

@tseaver
Copy link
Contributor Author

tseaver commented Oct 14, 2015

Hmmm? The updated scope is listed on each of the API pages under "Authentication", e.g.:

@dhermes
Copy link
Contributor

dhermes commented Oct 14, 2015

OK. How and why and when did it change? (If you know.)

@tseaver
Copy link
Contributor Author

tseaver commented Oct 15, 2015

I think I copied it in from the PR by @jgeewax (but don't recall). I found the issue today while beginning work on system tests for the API.

@dhermes
Copy link
Contributor

dhermes commented Oct 15, 2015

Ahhh I see. DERP

LGTM

tseaver added a commit that referenced this pull request Oct 15, 2015
@tseaver
Merge pull request #1183 from tseaver/search-correct_scope
0b19738 
Fix scope used for Cloud Search.
@tseaver tseaver merged commit 0b19738 into googleapis:master Oct 15, 2015
@tseaver tseaver deleted the search-correct_scope branch October 15, 2015 02:07
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot