Refactor 'gcloud.streaming.http_wrapper' exception handling #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Catch only explicitly retryable exceptions, and handle retry count / interval explicitly in 'make_api_request'. - Delete the 'handle_heep_exceptions' helper, and the 'retry_func' argument which used it as a default. - Rename '_rebuild_http_connections' -> '_reset_http_connections' for clarity. Closes #1223.
googlebot
added
the
cla: yes
|
Happy to see this! I had to peek into this mess a bit for #1248. If they collide for merging, let's stick with this one first. |
| @@ -399,11 +345,23 @@ def _make_api_request_no_retry(http, http_request, redirections=5, | |||
| return response | |||
|
|
|||
|
|
|||
| _RETRYABLE_EXCEPTIONS = ( | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Wow this was so much less work than I expected. w00t |
|
LGTM |
|
OK. The new commit since I reviewed is due to the |
dhermes
added a commit
that referenced
this pull request
Nov 30, 2015
…on_handling Refactor 'gcloud.streaming.http_wrapper' exception handling
Yes: it provoked an |
|
OK Good deal. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_api_request.handle_heep_exceptionshelper, and theretry_funcargument which used it as a default._rebuild_http_connections->_reset_http_connectionsfor clarity.Closes #1223.