Reducing datastore commit reliance on structure of response. #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Also moving out the response parsing into a helper which can be monkey-patched out during testing. This is for the `v1beta2` to `v1beta3` change. Currently the `CommitResponse` object contains a single `MutationResult` that holds an integer `index_updates` field and a repeated field (`insert_auto_id_key`) of partial `Key`s that were completed in the `commit`. In `v1beta3`, the `CommitResponse` directly holds the integer `index_updates` as well as a list of `MutationResult`s. Additionally, the definition of `MutationResult` no longer has `index_updates` (obviously given the last sentence) and no longer holds a list of `Key`s. Instead, it holds a single `Key` in the `key` field. What's more, the list of `MutationResult`s corresponds to every single `Entity` modified in the commit. For those where a partial `Key` was completed, the `MutationResult.key` holds the new key. For those were **no key was completed**, `MutationResult.key` is empty.
dhermes
force-pushed
the
datastore-commit-change-result
branch
from
c48c8bf to
607a05b
Compare
| mut_result = commit_response_pb.mutation_result | ||
| index_updates = mut_result.index_updates | ||
| completed_keys = list(mut_result.insert_auto_id_key) | ||
| return index_updates, completed_keys |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Dec 22, 2015
Reducing datastore commit reliance on structure of response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moving out the response parsing into a helper which can
be monkey-patched out during testing.
This is for the
v1beta2tov1beta3change. Currently theCommitResponseobject contains a singleMutationResultthat holdsan integer
index_updatesfield and a repeated field (insert_auto_id_key)of partial
Keys that were completed in thecommit.In
v1beta3, theCommitResponsedirectly holds the integerindex_updatesas well as a list of
MutationResults. Additionally, the definition ofMutationResultno longer hasindex_updates(obviously given the lastsentence) and no longer holds a list of
Keys. Instead, it holds a singleKeyin thekeyfield. What's more, the list ofMutationResultscorresponds to every single
Entitymodified in the commit. For thosewhere a partial
Keywas completed, theMutationResult.keyholds thenew key. For those were no key was completed,
MutationResult.keyis empty.