-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Row.commit() in Bigtable. #1471
Conversation
def clear_mutations(self): | ||
"""Removes all currently accumulated mutations on the current row.""" | ||
if self._filter is None: | ||
self._pb_mutations[:] = [] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
FYI @tseaver I am sending another commit to allow a different number of module lines for our test |
expected_result = predicate_matched | ||
|
||
# Perform the method and check the result. | ||
row.set_cell(column_family_id, column, value, state=True) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The pylint change seems OK: maybe disabling |
I disagree. Exceeding our pre-set limit is always a good signal that we should at least be notified about (even if we choose to ignore it). |
@tseaver PTAL, addressed the previous 2 comments |
LGTM pending Travis. |
Thanks. Just a heads up: I'm going to squash into a single commit before merging but will not change the content. |
SGTM |
Also - Adding pylint config to allow more lines in test modules. - Making small docstring change to HappyBase connection
321435e
to
64b8ef0
Compare
Implementing Row.commit() in Bigtable.
No description provided.