Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Row.commit() in Bigtable. #1471

Merged
merged 1 commit into from
Feb 15, 2016
Merged

Implementing Row.commit() in Bigtable. #1471

merged 1 commit into from
Feb 15, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 15, 2016

No description provided.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2016
tseaver
tseaver reviewed Feb 15, 2016
View reviewed changes
gcloud/bigtable/row.py
def clear_mutations(self):
"""Removes all currently accumulated mutations on the current row."""
if self._filter is None:
self._pb_mutations[:] = []

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor Author

dhermes commented Feb 15, 2016

FYI @tseaver I am sending another commit to allow a different number of module lines for our test pylint config.

tseaver
tseaver reviewed Feb 15, 2016
View reviewed changes
gcloud/bigtable/test_row.py
expected_result = predicate_matched

# Perform the method and check the result.
row.set_cell(column_family_id, column, value, state=True)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Feb 15, 2016

The pylint change seems OK: maybe disabling too-many-lines altogether for test modules would be better?

@dhermes
Copy link
Contributor Author

dhermes commented Feb 15, 2016

I disagree. Exceeding our pre-set limit is always a good signal that we should at least be notified about (even if we choose to ignore it).

@dhermes
Copy link
Contributor Author

dhermes commented Feb 15, 2016

@tseaver PTAL, addressed the previous 2 comments

@tseaver
Copy link
Contributor

tseaver commented Feb 15, 2016

LGTM pending Travis.

@dhermes
Copy link
Contributor Author

dhermes commented Feb 15, 2016

Thanks. Just a heads up: I'm going to squash into a single commit before merging but will not change the content.

@tseaver
Copy link
Contributor

tseaver commented Feb 15, 2016

SGTM

@dhermes
Implementing Row.commit() in Bigtable.
64b8ef0 
Also
- Adding pylint config to allow more lines in test modules.
- Making small docstring change to HappyBase connection
dhermes added a commit that referenced this pull request Feb 15, 2016
@dhermes
Merge pull request #1471 from dhermes/bigtable-row-commit
9e08e57 
Implementing Row.commit() in Bigtable.
@dhermes dhermes merged commit 9e08e57 into googleapis:master Feb 15, 2016
@dhermes dhermes deleted the bigtable-row-commit branch February 15, 2016 22:08
@dhermes dhermes mentioned this pull request Feb 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot