Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Bigtable generated files. #1476

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Updating Bigtable generated files. #1476

merged 1 commit into from
Feb 17, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 16, 2016

No description provided.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 16, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 16, 2016
@tseaver
Copy link
Contributor

tseaver commented Feb 16, 2016

Are the .proto files generated? Or are we just copying them into the _generated package for clarity?

Also, do we have the process for re-generating these files documented?

@dhermes
Copy link
Contributor Author

dhermes commented Feb 16, 2016

  1. The .proto files are copied from https://github.com/GoogleCloudPlatform/cloud-bigtable-client
  2. Coping the .proto files is there for clarity / as a reference for the relevant concepts. IIRC it was your original encouragement (for datastore) that led us to start including them.
  3. They are generated via make generate

@tseaver
Copy link
Contributor

tseaver commented Feb 16, 2016

They are generated via make generate

At one point, I wanted to work on the Makefile, but couldn't figure out how to reproduce the environment it expected.

@dhermes
Copy link
Contributor Author

dhermes commented Feb 16, 2016

Yeah it relies on gRPC being easy to install, which is not quite there yet. And AFAIK there is no good way to get the grpc_python_plugin without building from source.

@tseaver tseaver mentioned this pull request Feb 17, 2016
Closed
@tseaver
Copy link
Contributor

tseaver commented Feb 17, 2016

I opened #1482 to track the build-from-protos issue. LGTM.

dhermes added a commit that referenced this pull request Feb 17, 2016
@dhermes
Merge pull request #1476 from dhermes/bigtable-update-generated
4ca596c 
Updating Bigtable generated files.
@dhermes dhermes merged commit 4ca596c into googleapis:master Feb 17, 2016
@dhermes dhermes deleted the bigtable-update-generated branch February 17, 2016 15:34
@dhermes dhermes mentioned this pull request Feb 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot