Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Bigtable docs. #1547

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Adding Bigtable docs. #1547

merged 1 commit into from
Feb 29, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 26, 2016

Docs serving (for now at least, as of 12:45pm Pacific on Feb. 26): https://blog.bossylobster.com/gcloud-python/latest/bigtable-usage.html

@dhermes dhermes added docs api: bigtable Issues related to the Bigtable API. labels Feb 26, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Feb 26, 2016

@jgeewax PTAL as well

Bigtable Row
============

A

This comment was marked as spam.

@theacodes
Copy link
Contributor

Does it make sense to stuff the autogen stuff under a ref folder?

@theacodes
Copy link
Contributor

Finished a pass, please let me know when you're ready for another round.

>>> from gcloud import bigtable
>>> client = bigtable.Client()

or pass in ``credentials`` and ``project`` explicitly

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor Author

dhermes commented Feb 27, 2016

@jonparrott Just pushed a new commit PTAL. I did a full pass to make sure things still made sense (since the API has changed over time) and found a few changes to make here and there (many are stylistic).

@theacodes
Copy link
Contributor

This LGTM once @jgeewax's comments are addressed.

(Also don't forget to squash)

@dhermes
Copy link
Contributor Author

dhermes commented Feb 29, 2016

Thanks

@dhermes
Copy link
Contributor Author

dhermes commented Feb 29, 2016

Dangling questions to be resolved when #1548 is. Merging now.

dhermes added a commit that referenced this pull request Feb 29, 2016
@dhermes dhermes merged commit 944b27e into googleapis:master Feb 29, 2016
@dhermes dhermes deleted the bigtable-docs branch February 29, 2016 19:55
@jgeewax
Copy link
Contributor

jgeewax commented Mar 3, 2016

I see this one is merged -- are the docs up to date on both gh-pages and gcloud-python.readthedocs.org? (http://gcloud-python.readthedocs.org/en/latest/happybase-package.html doesn't look like the demo)

@jgeewax
Copy link
Contributor

jgeewax commented Mar 3, 2016

/cc @dhermes

@dhermes
Copy link
Contributor Author

dhermes commented Mar 3, 2016

AFK right now but will try to sleuth. Looks like the docs build is broken somehow

@dhermes
Copy link
Contributor Author

dhermes commented Mar 8, 2016

@jgeewax confirmed the build failure: https://readthedocs.org/projects/gcloud-python/builds/3798705/

For example:

/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/docs/happybase-table.rst:4: WARNING: autodoc: failed to import module u'gcloud.bigtable.happybase.table'; the following exception was raised:
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/envs/latest/local/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 385, in import_object
    __import__(self.modname)
  File "/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/gcloud/bigtable/__init__.py", line 18, in <module>
    from gcloud.bigtable.client import Client
  File "/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/gcloud/bigtable/client.py", line 32, in <module>
    from grpc.beta import implementations
ImportError: No module named grpc.beta

I forgot I had a hack in place and will do something similar (but closer to the recommended way of fixing bad imports).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants