-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Bigtable docs. #1547
Adding Bigtable docs. #1547
Conversation
@jgeewax PTAL as well |
Bigtable Row | ||
============ | ||
|
||
A |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Does it make sense to stuff the autogen stuff under a |
Finished a pass, please let me know when you're ready for another round. |
>>> from gcloud import bigtable | ||
>>> client = bigtable.Client() | ||
|
||
or pass in ``credentials`` and ``project`` explicitly |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@jonparrott Just pushed a new commit PTAL. I did a full pass to make sure things still made sense (since the API has changed over time) and found a few changes to make here and there (many are stylistic). |
7735980
to
3ac5294
Compare
This LGTM once @jgeewax's comments are addressed. (Also don't forget to squash) |
Thanks |
3ac5294
to
9eda391
Compare
Dangling questions to be resolved when #1548 is. Merging now. |
I see this one is merged -- are the docs up to date on both gh-pages and gcloud-python.readthedocs.org? (http://gcloud-python.readthedocs.org/en/latest/happybase-package.html doesn't look like the demo) |
/cc @dhermes |
AFK right now but will try to sleuth. Looks like the docs build is broken somehow |
@jgeewax confirmed the build failure: https://readthedocs.org/projects/gcloud-python/builds/3798705/ For example: /home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/docs/happybase-table.rst:4: WARNING: autodoc: failed to import module u'gcloud.bigtable.happybase.table'; the following exception was raised:
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/envs/latest/local/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 385, in import_object
__import__(self.modname)
File "/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/gcloud/bigtable/__init__.py", line 18, in <module>
from gcloud.bigtable.client import Client
File "/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/gcloud/bigtable/client.py", line 32, in <module>
from grpc.beta import implementations
ImportError: No module named grpc.beta I forgot I had a hack in place and will do something similar (but closer to the recommended way of fixing bad imports). |
Docs serving (for now at least, as of 12:45pm Pacific on Feb. 26): https://blog.bossylobster.com/gcloud-python/latest/bigtable-usage.html