Add 'Sink.create' API wrapper and 'Client.sink' factory. #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -53,3 +54,22 @@ def logger(self, name): | |||
| :returns: Logger created with the current client. | |||
| """ | |||
| return Logger(name, client=self) | |||
|
|
|||
| def sink(self, name, filter_, destination): | |||
| """Creates a sink bound to the current client. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Mostly looks good but
|
| @@ -56,6 +57,7 @@ def logger(self, name): | |||
| """ | |||
| return Logger(name, client=self) | |||
|
|
|||
| <<<<<<< HEAD | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM pending Travis. Squash if it pleases you. I have found it quite easy in my workflow to do: $ git checkout branch-working-on
$ git reset HEAD^
$ # Repeat for as many commits need to be squashed
$ git add -p . # I make sure I am adding the right stuff
$ git commit --amend # Just save itand then the amend will add back the staged contents to the original base commit. |
|
Squashed. I will merge after Travis passes. |
|
I've been using |
tseaver
added a commit
that referenced
this pull request
Mar 11, 2016
Add 'Sink.create' API wrapper and 'Client.sink' factory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR punts on any answer to #1591.