Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise appropriate exception when upload fails. #1717

Merged
merged 2 commits into from
Apr 18, 2016
Merged

Raise appropriate exception when upload fails. #1717

merged 2 commits into from
Apr 18, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 11, 2016 •
edited
Loading

Closes #1712.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Apr 11, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2016
@tseaver tseaver mentioned this pull request Apr 11, 2016
Closed
dhermes
dhermes reviewed Apr 11, 2016
View reviewed changes
gcloud/storage/blob.py
info = http_response.info
status = int(info['status'])
if not 200 <= status < 300:
faux_response = _FauxResponse(status)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Apr 18, 2016

LGTM

@dhermes
Copy link
Contributor

dhermes commented Apr 18, 2016

@tseaver This is #1717. Which issue is this supposed to close?

@dhermes
Copy link
Contributor

dhermes commented Apr 18, 2016

Ahhh I see in the branch name #1712.

@tseaver tseaver merged commit 5d6c3c6 into googleapis:master Apr 18, 2016
@tseaver tseaver deleted the 1712-storage-upload_drops_40x_errors_on_floor branch April 18, 2016 20:17
@daspecster daspecster mentioned this pull request Apr 19, 2016
Merged
@tseaver tseaver mentioned this pull request Sep 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot