Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LICENSE headers to gcloud.streaming. #2004

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 20, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2016

@tseaver The failure is lint:

C:  1, 0: Too many lines in module (1213/1200) (too-many-lines)

I can temporarily disable for the file or temporarily raise the limit and deal with after this PR? I'm expecting to lean out this code a bit as I pass through to factor out httplib2 dependencies.

@daspecster
Copy link
Contributor

I think that's fine. It's barely 1% over.
If you're worried about remembering this later, you could make an issue.

@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2016

@daspecster I was asking @tseaver because he dislikes the churn (as do I) in the settings

@daspecster
Copy link
Contributor

Gotcha,
Couldn't you just add something like this to this particular module?
# pylint: disable=C0321
until the refactoring happens?

@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2016

Yup that was

I can temporarily disable for the file

but I wouldn't use the obfuscated C0321 I'd use too-many-lines to make it clear

@dhermes
Copy link
Contributor Author

dhermes commented Jul 21, 2016

@tseaver PTAL

@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2016

Grrr, arbirtray limits bite us again. Go ahead with a per-file override, I think.

@tseaver
Copy link
Contributor

tseaver commented Jul 21, 2016

LGTM once pylint is appeased.

@dhermes dhermes merged commit a460b3f into googleapis:master Jul 21, 2016
@dhermes dhermes deleted the streaming-license-headers branch July 21, 2016 18:38
This was referenced Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants