Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Group support to the Monitoring API #2035

Merged
merged 8 commits into from
Aug 4, 2016
Merged

Add Group support to the Monitoring API #2035

merged 8 commits into from
Aug 4, 2016

Commits on Aug 3, 2016

  1. Add Group support to the Monitoring API 

    Users can now fetch and list Stackdriver groups, and list a group's
members.
    @supriyagarg
    supriyagarg committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    cc0f814 View commit details
    Browse the repository at this point in the history

  2. Added support for creating and deleting Stackdriver groups. 

    Also allow a user to specify either the group ID or name to initilize
it. The client class now has a factory constructor groups.
    @supriyagarg
    supriyagarg committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    0018b01 View commit details
    Browse the repository at this point in the history

  3. Added support for updating Stackdriver groups.

    @supriyagarg
    supriyagarg committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    335d909 View commit details
    Browse the repository at this point in the history

  4. Add system tests for the groups API under monitoring.

    @supriyagarg
    supriyagarg committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    cedca63 View commit details
    Browse the repository at this point in the history

  5. Change Groups API to take group and parent IDs as the inputs. 

    The fully qualified names are set by the class based on client.project.
Also, the property Group.id can only be set during initialization now.
    @supriyagarg
    supriyagarg committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    c795598 View commit details
    Browse the repository at this point in the history

  6. Remove the helpers module from monitoring API. 

    This commit makes the code consistent with the update to
the helper function _datetime_to_rfc3339.
    @supriyagarg
    supriyagarg committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    3b3a996 View commit details
    Browse the repository at this point in the history

  7. Edits to the Groups API 

    * Renamed some of the methods of gcloud.monitoring.Groups that get data
  from the API:
  * parent -> fetch_parent
  * members -> list_members
  * children -> list_children
  * ancestors -> list_ancestors
  * descendants -> list_descendants

* Renamed / deleted some helper methods
  * group_id_from_name -> _group_id_from_name
  * _group_name_from_id -> _group_name_from_id
  * _init_from_dict -> _set_properties_from_dict
  * delete path_helper

* Minimized the payload while checking if a group exists.

* Updated the docstrings to be more consistent. Especially added
  examples where the group ID is not an integer.
    @supriyagarg
    supriyagarg committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    d205cec View commit details
    Browse the repository at this point in the history

  8. Remove retries during system tests for group.

    @supriyagarg
    supriyagarg committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    5dfa1be View commit details
    Browse the repository at this point in the history