Playing with retries.

[daspecster]

So I was playing with getting the retries working on the bigquery system3 tests.

I'm not sure what fixtures need to be created to get all the tests passing but this seemed to get the bigquery tests to pass.

Also, I have the retry set pretty long, looks like it takes about an average of 20 seconds for it to eventually be consistent.

[daspecster]

Sorry, I should have put more in the description I think.

So my point with this, was that there are a lot more errors after the main blocking bigquery error that we keep seeing. I'm sure this isn't the best solution.

When I run system-tests I get a bunch of datastore failures/errors. Are there some fixtures I need to setup to get those to work?

I can fix this up so we can merge and go from there though.

[dhermes]

There is nothing wrong with the retry method, it just looks copy-pasted. You'd probably rather use it inside the test case than on the test case:

def test_case_for_thing(self):
    # do some set-up
    @retry(...)
    def thing_that_is_eventually_consistent():
        global_object.some_method(args)

    thing_that_is_eventually_consistent()

[daspecster]

@dhermes LMKWYT.

[dhermes]

Thanks for taking the initiative here.

Searching
https://github.com/GoogleCloudPlatform/gcloud-python/search?q=eventual+consistency&type=Issues
https://github.com/GoogleCloudPlatform/gcloud-python/search?q=eventually+consistent&type=Issues
we should unify all the issues / code that have consistency implications.

In particular, we should discuss this in #1619

[daspecster]

@dhermes here's the class version of the retry decorator. LMWYT.

[dhermes]

LGTM pending Travis