Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating INVALID_ARGUMENT on datastore commit to standard exception. #2423

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 26, 2016

NOTE Has #2417 as diffbase.

Fixes #2422.

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Sep 26, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 26, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 26, 2016

Rut-roh. Bad rebase. All better.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 26, 2016
@tseaver
Copy link
Contributor

tseaver commented Sep 26, 2016

4100215 LGTM. I don't see any reason it needs to wait for #2417, though (could just be rebased to master).

@dhermes
Copy link
Contributor Author

dhermes commented Sep 26, 2016

I did it to avoid rebase issues. The renames / moves should be done ASAP so we can stop worrying about this.

@dhermes dhermes merged commit 79a5a78 into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the fix-2422 branch September 26, 2016 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants