Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading versions of GAPIC and gRPC generated libraries. #2453

Merged
merged 2 commits into from
Sep 28, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 27, 2016

This resolves the google-gax 0.14.* conflict.

As a side effect this should finally fix the RTD build breakage.

/cc @bjwatson

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 27, 2016

See googleapis/gapic-generator#526, we had another issue with positional vs. keyword args. So I made a commit to defensively use keyword arguments ONLY as keywords.

Check out the signatures from the 0.9.x versions we were using (I kept a diff around in case reviewers cared).

@dhermes dhermes merged commit c6145c7 into googleapis:master Sep 28, 2016
@dhermes dhermes deleted the upgrade-gapic-deps branch September 28, 2016 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. grpc packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants