Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating list_sinks() to Iterator pattern. #2652

Merged
merged 4 commits into from
Oct 31, 2016
Merged

Updating list_sinks() to Iterator pattern. #2652

merged 4 commits into from
Oct 31, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 31, 2016 •
edited
Loading

NOTE: Has #2651 as diffbase. Unit test changes will be forthcoming.

@dhermes dhermes added the api: logging Issues related to the Cloud Logging API. label Oct 31, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Oct 31, 2016

@tseaver @daspecster PTAL this is ready to go

@dhermes dhermes force-pushed the logging-iterators-sinks branch from d4cd270 to 035ec7f Compare October 31, 2016 22:39
@dhermes dhermes mentioned this pull request Oct 31, 2016
Merged
daspecster
daspecster reviewed Oct 31, 2016
View reviewed changes
logging/google/cloud/logging/_helpers.py
@@ -24,7 +24,7 @@ def entry_from_resource(resource, client, loggers):
"""Detect correct entry type from resource and instantiate.

:type resource: dict
:param resource: one entry resource from API response
:param resource: One entry resource from API response.

This comment was marked as spam.

Sign in to view

daspecster
daspecster reviewed Oct 31, 2016
View reviewed changes
logging/unit_tests/test_connection.py

self.assertEqual(sinks, RETURNED['sinks'])
# First check the token.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor

This LGTM as well.

@dhermes dhermes force-pushed the logging-iterators-sinks branch from 035ec7f to c351c05 Compare October 31, 2016 23:16
@dhermes dhermes merged commit 94aa18c into googleapis:master Oct 31, 2016
@dhermes dhermes deleted the logging-iterators-sinks branch October 31, 2016 23:22
tseaver
tseaver reviewed Nov 1, 2016
View reviewed changes
logging/unit_tests/test__gax.py

self.assertEqual(sinks, SINKS)
# First check the token.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver reviewed Nov 1, 2016
View reviewed changes
logging/unit_tests/test_client.py
iterator = client.list_sinks()
page = six.next(iterator.pages)
sinks = list(page)
token = iterator.next_page_token

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes mentioned this pull request Nov 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#2652 from dhermes/logging-iterators-sinks
9547388 
Updating list_sinks() to Iterator pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@daspecster daspecster daspecster left review comments

Assignees

@tseaver tseaver

Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @daspecster @tseaver @googlebot