Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DON'T MERGE: Fix cyclic imports #267

Closed
wants to merge 2 commits into from
Closed

DON'T MERGE: Fix cyclic imports #267

wants to merge 2 commits into from

Commits on Oct 20, 2014

  1. Resolving cyclic imports in storage package. 

    This is accomplished by moving the definitions of
BucketIterator and KeyIterator into their respective
modules (i.e. storage.bucket and storage.key).

This is not so big an issue because the parent class
iterator.Iterator does most of the work and the children
only require a small tweak.
    @dhermes
    dhermes committed Oct 20, 2014
    Configuration menu
    Copy the full SHA
    3148468 View commit details
    Browse the repository at this point in the history

  2. Temp commit with idea to clear up cyclic imports in datastore package. 

    This is intended for discussion but not to be committed. Some remarks:

- This surfaces the fact that the use of Dataset in
  datastore.key.Key.from_protobuf is not well-tested enough.
- The changes to _helpers are made to avoid explicitly referencing
  the Entity class. These changes end up in uglier code
  for a minimal gain.
- We could likely factor out the Dataset ID/connection concept from
  the full "dataset" concept. It seems a Dataset and its convenience
  methods are referenced a lot in the docs but not really tested
  much.
    @dhermes
    dhermes committed Oct 20, 2014
    Configuration menu
    Copy the full SHA
    0a72dc4 View commit details
    Browse the repository at this point in the history