-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reference to bounds. #2833
Update reference to bounds. #2833
Conversation
Cancelled CI since it's just a docs change. |
78 | ||
>>> landmarks[0].bounding_poly.vertices[0].y_coordinate | ||
>>> landmarks[0].bounds.vertices[0].y_coordinate |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please for the love of crepes stop doing things like
landmarks[0].bounds.vertices[0].x_coordinate
Yeah, I'm trying to clean those up as I go. |
…te-for-landmark Update reference to bounds.
Towards #2753
Old references to
bounding_poly
->bounds
.