Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reference to bounds. #2833

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Update reference to bounds. #2833

merged 1 commit into from
Dec 8, 2016

Conversation

daspecster
Copy link
Contributor

Towards #2753

Old references to bounding_poly -> bounds.

@daspecster daspecster added the api: vision Issues related to the Cloud Vision API. label Dec 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2016
@daspecster
Copy link
Contributor Author

Cancelled CI since it's just a docs change.

tseaver
tseaver reviewed Dec 7, 2016
View reviewed changes
docs/vision-usage.rst
78
>>> landmarks[0].bounding_poly.vertices[0].y_coordinate
>>> landmarks[0].bounds.vertices[0].y_coordinate

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster daspecster mentioned this pull request Dec 7, 2016
Closed
10 tasks
dhermes
dhermes approved these changes Dec 8, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please for the love of crepes stop doing things like

landmarks[0].bounds.vertices[0].x_coordinate

@daspecster
Copy link
Contributor Author

Yeah, I'm trying to clean those up as I go.

@daspecster daspecster merged commit 06d78fc into googleapis:master Dec 8, 2016
@daspecster daspecster deleted the vision-readme-update-for-landmark branch December 8, 2016 22:25
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#2833 from daspecster/vision-readme-upda…
0035ee6 
…te-for-landmark

Update reference to bounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@dhermes dhermes dhermes approved these changes

Assignees

@tseaver tseaver

Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspecster @tseaver @dhermes @googlebot