Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2753
TL;DR This PR just adds the beginning of the
_GAPICVisionAPI
class andClient
branching.I started just doing the straight up conversion but it got huge.
Then I tried just converting face annotations and that got huge.
So this is part 1 of many, hopefully small PRs to add this in.
There are a lot of classes that will need the
from_pb
added to them and also test splitting to support both since the JSON responses vary in the value names a lot from the proto responses.So for starters this was the smallest chunk I could come up with. Next up I will be adding the
annotate
method which requires some interesting helpers to translateFeature
andImage
s.