Add a starter class for _gax. #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
approved these changes
Dec 28, 2016
| :param client: Instance of ``Client`` object. | ||
| """ | ||
| def __init__(self, client=None): | ||
| raise NotImplementedError |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…rter-class Add a starter class for _gax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2753
TL;DR This PR just adds the beginning of the
_GAPICVisionAPIclass andClientbranching.I started just doing the straight up conversion but it got huge.
Then I tried just converting face annotations and that got huge.
So this is part 1 of many, hopefully small PRs to add this in.
There are a lot of classes that will need the
from_pbadded to them and also test splitting to support both since the JSON responses vary in the value names a lot from the proto responses.So for starters this was the smallest chunk I could come up with. Next up I will be adding the
annotatemethod which requires some interesting helpers to translateFeatureandImages.