Moving Bigtable helpers for duration protobufs into core. #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@dhermes It looks like the two differ for negative durations, which means the version in Bigtable is more likely correct. Why don't we promote that function (and the |
dhermes
force-pushed
the
upstream-timestamp-changes
branch
from
ba4c2e1 to
dd25e45
Compare
|
@tseaver SGTM. I wanted to double-check before doing that. PTAL. I just went with the existing name: |
dhermes
changed the title
Works for me: I will adjust the private branch accordingly after merging from master. |
tseaver
approved these changes
Jan 20, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…anges Moving Bigtable helpers for duration protobufs into core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is from a private branch of @tseaver. Though it largely copies a function from Bigtable so I'm not sure how to proceed here.@tseaver Can you weigh in?
/cc @geigerj