Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Spanner tests for grpcio 1.2.0 #3178

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

lukesneeringer
Copy link
Contributor

The GRPC team released grpcio 1.2.0 yesterday, and renamed an internal method that we were using directly in our Spanner unit tests. This PR updates us to use the new name.

See #3170 for the original build failure.

@lukesneeringer lukesneeringer self-assigned this Mar 21, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2017
@lukesneeringer lukesneeringer merged commit 10f5520 into googleapis:master Mar 21, 2017
@lukesneeringer lukesneeringer deleted the fix-grpc-1.2 branch March 21, 2017 16:47
@@ -847,15 +847,15 @@ def begin_transaction(self, session, options_, options=None):
def _trailing_metadata(self):
from google.protobuf.duration_pb2 import Duration
from google.rpc.error_details_pb2 import RetryInfo
from grpc._common import cygrpc_metadata
from grpc._common import to_cygrpc_metadata

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants