New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry test #3279

Closed

calpeyser wants to merge 3 commits into googleapis:master from calpeyser:retry_test

Contributor

calpeyser commented Apr 6, 2017

No description provided.

calpeyser added 3 commits

March 28, 2017 22:34


          testing

62384ed


          retryable in place

7c6523d


          add retries and integration test

470ccfc

googlebot commented Apr 6, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

googlebot added the cla: no label

calpeyser mentioned this pull request

Retry temporary failures for Bigtable scans #2255

Closed

lukesneeringer suggested changes

View reviewed changes

Contributor

lukesneeringer left a comment

Hi @calpeyser,
Thanks for submitting your PR. We are really grateful.

I have a few issues that I would appreciate if you could look into before I can merge. (Also, CI needs to pass.)

Thanks!

bigtable/unit_tests/retry_server.go

		@@ -0,0 +1,295 @@
		package main

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/table.py

+              from google.cloud.bigtable.retry import ReadRowsIterator, _create_row_request
+              from grpc import StatusCode
+              BACKOFF_SETTINGS = BackoffSettings(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/table.py

@@ @@ -13,8 +13,10 @@ @@
               # limitations under the License.
               """User friendly container for Google Cloud Bigtable Table."""
+              from __future__ import absolute_import, division

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/retry.py

+                          self.total_timeout = (retry_options.backoff_settings.total_timeout_millis / _MILLIS_PER_SECOND)
+                          self.set_stream()
+                  def set_start_key(self, start_key):

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/retry.py

+                      while deadline is None or now < deadline:
+                          try:
+                              return six.next(self.stream)
+                          except StopIteration as stop:

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/retry.py

+                              return six.next(self.stream)
+                          except StopIteration as stop:
+                              raise stop
+                          except Exception as exception:  # pylint: disable=broad-except

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/retry.py

+                          except Exception as exception:  # pylint: disable=broad-except
+                              code = config.exc_to_code(exception)
+                              if code not in self.retry_options.retry_codes:
+                                  raise errors.RetryError(

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/retry.py

+                                      ' classified as transient', exception)
+                              # pylint: disable=redefined-variable-type
+                              exc = errors.RetryError(

This comment was marked as spam.

Sign in to view

garye suggested changes

View reviewed changes

Contributor

garye left a comment

Thanks for putting this together!

bigtable/unit_tests/test_table.py

		@@ -1,599 +0,0 @@
		# Copyright 2015 Google Inc.

This comment was marked as spam.

Sign in to view

bigtable/unit_tests/test_retry.py

+                  def process_write(self, table, payload):
+                      pass
+                  def process_scan(self, table, range, ids):

This comment was marked as spam.

Sign in to view

bigtable/unit_tests/test_retry.py

		@@ -0,0 +1,54 @@
		import unittest

This comment was marked as spam.

Sign in to view

bigtable/unit_tests/retry_server.go

		@@ -0,0 +1,295 @@
		package main

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/table.py

+              from google.cloud.bigtable.retry import ReadRowsIterator, _create_row_request
+              from grpc import StatusCode
+              BACKOFF_SETTINGS = BackoffSettings(

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/row_data.py

@@ @@ -274,6 +274,9 @@ def consume_next(self): @@
                           self._validate_chunk(chunk)
+                          if ("ReadRowsIterator" in self._response_iterator.__class__.__name__):
+                              self._response_iterator.set_start_key(chunk.row_key)

This comment was marked as spam.

Sign in to view

tseaver added the api: bigtable label

lukesneeringer added the priority: p2 label

tseaver mentioned this pull request

RPC retries (second PR) #3324

Merged

Contributor

tseaver commented May 15, 2017

Superseded by #3324

tseaver closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable cla: no priority: p2