-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Part Of Speech missing data to Token #3457
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. (Thanks for all your work, @dvaldivia!)
@lukesneeringer you are welcome :) What's next? Do I need to do anything else? |
@@ -20,7 +20,45 @@ | |||
|
|||
|
|||
class PartOfSpeech(object): | |||
"""Part of speech of a :class:`Token`.""" | |||
"""A Google Cloud Natural Language API Part of speech object. | |||
Rich data about the Part of Speech of a token returned by the API |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
import unittest | ||
from copy import copy |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@dhermes did as you requested, let me know if I should change anything else. |
Add support for all the data returned by the API for PartOfSpeech inside Token.
Add support for all the data returned by the API for PartOfSpeech inside Token.
Add support for all the data returned by the API for PartOfSpeech inside Token.
Add support for all the data returned by the API for PartOfSpeech inside Token.
Hi,
This PR add the missing data returned by the API to the Token, before only the Tag was being returned, I added all the data to the existing PartOfSpeech object and replaced it's hydratation on the Token as well