Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Part Of Speech missing data to Token #3457

Merged
merged 11 commits into from
Jun 5, 2017
Merged

Conversation

dvaldivia
Copy link
Contributor

Hi,

This PR add the missing data returned by the API to the Token, before only the Tag was being returned, I added all the data to the existing PartOfSpeech object and replaced it's hydratation on the Token as well

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 29, 2017
@dvaldivia
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 29, 2017
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. (Thanks for all your work, @dvaldivia!)

@dvaldivia
Copy link
Contributor Author

@lukesneeringer you are welcome :) What's next? Do I need to do anything else?

@@ -20,7 +20,45 @@


class PartOfSpeech(object):
"""Part of speech of a :class:`Token`."""
"""A Google Cloud Natural Language API Part of speech object.
Rich data about the Part of Speech of a token returned by the API

This comment was marked as spam.

import unittest
from copy import copy

This comment was marked as spam.

@dvaldivia
Copy link
Contributor Author

@dhermes did as you requested, let me know if I should change anything else.

@tseaver tseaver added the api: language Issues related to the Cloud Natural Language API API. label Jun 5, 2017
@tseaver tseaver merged commit b0abcb2 into googleapis:master Jun 5, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
Add support for all the data returned by the API for PartOfSpeech inside Token.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add support for all the data returned by the API for PartOfSpeech inside Token.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Add support for all the data returned by the API for PartOfSpeech inside Token.
parthea pushed a commit that referenced this pull request Jul 6, 2023
Add support for all the data returned by the API for PartOfSpeech inside Token.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants