Make the Spanner README better. #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
approved these changes
Aug 11, 2017
vkedia
reviewed
Aug 11, 2017
| # SQL injection attacks. | ||
| query = """UPDATE people | ||
| SET anniversary = @uxts | ||
| WHERE id = @person_id""" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vkedia
reviewed
Aug 11, 2017
| See the ``google-cloud-python`` API `Cloud Spanner documentation`_ to learn how | ||
| to connect to Cloud Spanner using this Client Library. | ||
|
|
||
| .. _Cloud Spanner documentation: https://googlecloudplatform.github.io/google-cloud-python/latest/bigquery/usage.html |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vkedia
reviewed
Aug 11, 2017
| .. _About Cloud Spanner: https://cloud.google.com/spanner/ | ||
|
|
||
|
|
||
| Executing Arbitrary SQL in a Transaction |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Merged
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @vkedia (/cc) pointed out, the existing README is pretty sparse. This improves it.
That said, I have barely used this library and would like to ensure that what I have here is correct and in line with the recommended ways to use the API.
Fixes #3238.