Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storage to 1.3.2. #3812

Closed
wants to merge 1 commit into from
Closed

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 14, 2017

Did this to update the lower bound on the requests dependency (see #3736).

Did this to update the lower bound on the `requests` dependency
(see googleapis#3736).
@dhermes dhermes added api: storage Issues related to the Cloud Storage API. packaging labels Aug 14, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2017
@dhermes
Copy link
Contributor Author

dhermes commented Aug 14, 2017

Blerg! #3770 means a core release would be needed for storage and #3737 means this should probably be a 1.4.x release.

😢

@theacodes
Copy link
Contributor

Ugh, I was worried about this.

We have two options:

  1. Keep revving core (& all dependent packages) every time we need a release until I'm done. (My ETA is ~1 month)
  2. Cherry-pick into a release branch and release from there.

@lukesneeringer WDYT?

@theacodes
Copy link
Contributor

Alternatively I can hold on off making any more breaking changes in core (basically don't remove any google.cloud packages and cut over depend usage until the very end).

@dhermes
Copy link
Contributor Author

dhermes commented Aug 14, 2017

Cherry-pick into a release branch and release from there.

My preference

@lukesneeringer
Copy link
Contributor

I have no preference. Whichever you two prefer since you are the ones doing the work.

@dhermes dhermes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 15, 2017
@dhermes dhermes closed this Aug 15, 2017
@dhermes dhermes deleted the storage-1.3.2 branch August 15, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants