Fix #81 getting a datastore.entity by key or path #393

bryanyang0528 · 2014-11-27T02:16:24Z

New can get a datastore.entity by key or path
#81

dhermes · 2014-11-27T02:44:50Z

Thanks for doing this! Can you address the lint errors in the Travis link?

Also, have you signed the CLA referenced in CONTRIBUTING.md?

If you'd like, I'd be happy to chat about how to run the tests locally (just running tox from the root of the repo gets most of the way there).

bryanyang0528 · 2014-11-27T04:59:52Z

Yes, I can address the lint errors, but not actually understood why errors happened yet. I'll try run tox locally for more detail information. I just ran nosetests and passed it before.

btw, I've signed CLA

coveralls · 2014-11-27T14:22:00Z

Coverage remained the same when pulling e47ccc1 on bryanyang0528:81-getting_a_datastore_entity_by_key into 3b90004 on GoogleCloudPlatform:master.

gcloud/datastore/dataset.py

+        if isinstance(key_or_path, Key):
+            entities = self.get_entities([key_or_path])
+        else:
+            key = Key.from_path(*key_or_path)


dhermes · 2014-11-27T17:25:15Z

@silvolu Can you verify the CLA? (No need to do it on a holiday, just eventually.)

dhermes · 2014-11-27T17:27:04Z

This fix doesn't cover @jgeewax suggestions like

dataset.entity('Person').get('jim')

so I'm not sure we should entirely close #81.

Though I think the discussion should move into a discussion about a port of https://code.google.com/p/appengine-ndb-experiment/

coveralls · 2014-11-28T07:58:40Z

Coverage remained the same when pulling e75899b on bryanyang0528:81-getting_a_datastore_entity_by_key into 3b90004 on GoogleCloudPlatform:master.

dhermes · 2014-11-28T18:44:01Z

LGTM. I'll hold off on merging until @tseaver has a chance to weigh in.

gcloud/datastore/test_dataset.py

+        from gcloud.datastore.connection import datastore_pb
+        DATASET_ID = 'DATASET'
+        KIND = 'Kind'
+        ID = 1234


coveralls · 2014-11-29T07:37:03Z

Coverage remained the same when pulling fd0f674 on bryanyang0528:81-getting_a_datastore_entity_by_key into 3b90004 on GoogleCloudPlatform:master.

tseaver · 2014-12-03T18:38:17Z

Hmm, looks like a transient failure in regression tests after the merge. Regression tests passed for me just now.

silvolu · 2014-12-03T18:48:10Z

Re-running the build now.

silvolu · 2014-12-03T20:58:15Z

Back to green after #406

)

…#393)

…p/templates/python_library/.kokoro (#393) Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 Source-Link: googleapis/googleapis-gen@1ee1a06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9

Source-Link: https://github.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

…p/templates/python_library/.kokoro (#393) Source-Link: https://github.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

* docs: Minor formatting chore: Update gapic-generator-python to v1.11.5 build: Update rules_python to 0.24.0 PiperOrigin-RevId: 563436317 Source-Link: googleapis/googleapis@42fd37b Source-Link: googleapis/googleapis-gen@280264c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://github.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc

…rLinks`, `UpdateUserLink`, `BatchCreateUserLinks`, `CreateUserLink`, `AuditUserLinks`, `ListUserLinks`, `BatchGetUserLinks`, `GetUserLink` from the Admin API v1 alpha as per the anno... (#393) * fix!: delete `BatchDeleteUserLinks`, `DeleteUserLink`, `BatchUpdateUserLinks`, `UpdateUserLink`, `BatchCreateUserLinks`, `CreateUserLink`, `AuditUserLinks`, `ListUserLinks`, `BatchGetUserLinks`, `GetUserLink` from the Admin API v1 alpha as per the announcement in https://bit.ly/46yBIDt feat: add `UpdateDataRedactionSettings`, `CreateRollupProperty`, `GetRollupPropertySourceLink`, `ListRollupPropertySourceLinks`, `CreateRollupPropertySourceLink`, `DeleteRollupPropertySourceLink`, `CreateSubproperty`, `CreateSubpropertyEventFilter`, `CreateSubpropertyEventFilter`, `ListSubpropertyEventFilters`, `UpdateSubpropertyEventFilter`, `DeleteSubpropertyEventFilter` methods to the Admin API v1 alpha feat: add `include_all_users`, `expand_groups` fields to `RunAccessReportRequest` feat: add `DataRedactionSettings`, `RollupPropertySourceLink`, `SubpropertyEventFilterCondition`, `SubpropertyEventFilterExpression`, `SubpropertyEventFilterExpressionList`, `SubpropertyEventFilterClause`, `SubpropertyEventFilter` types feat: add the `DATA_REDACTION_SETTINGS` option to the `ChangeHistoryResourceType` enum feat: add the `data_redaction_settings` field to the `ChangeHistoryResource.resource` oneof field PiperOrigin-RevId: 574877732 Source-Link: googleapis/googleapis@a3006dd Source-Link: googleapis/googleapis-gen@4eb740a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGViNzQwYTRjZjIxYzEzZDEzNzM3YjM0ODhmYTRjNzUyZTEzYjc5ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.11.7 PiperOrigin-RevId: 573230664 Source-Link: googleapis/googleapis@93beed3 Source-Link: googleapis/googleapis-gen@f4a4eda Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhNGVkYWE4MDU3NjM5ZmNmNmFkZjkxNzk4NzIyODBkMWE4ZjY1MSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.11.8 PiperOrigin-RevId: 574178735 Source-Link: googleapis/googleapis@7307199 Source-Link: googleapis/googleapis-gen@ce3af21 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2UzYWYyMWI3YzU1OWE4N2MyYmVmYzA3NmJlMGUzYWVkYTNhMjZmMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: https://github.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

getting a datastore.entity by key or path

2e1b026

bryanyang0528 added 2 commits November 27, 2014 16:54

del space

1806341

coding style revised

e47ccc1

dhermes reviewed Nov 27, 2014
View reviewed changes

gcloud/datastore/dataset.py

if isinstance(key_or_path, Key):

entities = self.get_entities([key_or_path])

else:

key = Key.from_path(*key_or_path)

This comment was marked as spam.

Sign in to view

add a test for odd list and nonetype

e75899b

silvolu added the cla: yes This human has signed the Contributor License Agreement. label Nov 28, 2014

tseaver reviewed Nov 28, 2014
View reviewed changes

del unused code

fd0f674

tseaver merged commit fd0f674 into googleapis:master Dec 3, 2014

dhermes mentioned this pull request Dec 17, 2014

Getting a datastore.entity by key name is a pain #81

Closed

parthea pushed a commit that referenced this pull request Jun 4, 2023

docs(samples): Added extra exception handling to operation samples (#393

57cede1

)

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-pubsub to v2.13.7 (#393)

0aea777

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-secret-manager to v2.15.1 (…

dff7ee2

…#393)

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore: release-please updates snippet metadata (#393)

c5f5d12

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 2.7.3 (#393)

139592f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

release-please bot mentioned this pull request Oct 31, 2023

chore: release main #11913

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #81 getting a datastore.entity by key or path #393

Fix #81 getting a datastore.entity by key or path #393

bryanyang0528 commented Nov 27, 2014

dhermes commented Nov 27, 2014

bryanyang0528 commented Nov 27, 2014

coveralls commented Nov 27, 2014

This comment was marked as spam.

dhermes commented Nov 27, 2014

dhermes commented Nov 27, 2014

coveralls commented Nov 28, 2014

dhermes commented Nov 28, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 29, 2014

tseaver commented Dec 3, 2014

silvolu commented Dec 3, 2014

silvolu commented Dec 3, 2014

Fix #81 getting a datastore.entity by key or path #393

Fix #81 getting a datastore.entity by key or path #393

Conversation

bryanyang0528 commented Nov 27, 2014

dhermes commented Nov 27, 2014

bryanyang0528 commented Nov 27, 2014

coveralls commented Nov 27, 2014

This comment was marked as spam.

dhermes commented Nov 27, 2014

dhermes commented Nov 27, 2014

coveralls commented Nov 28, 2014

dhermes commented Nov 28, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 29, 2014

tseaver commented Dec 3, 2014

silvolu commented Dec 3, 2014

silvolu commented Dec 3, 2014