Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'BucketNotification.reload' API wrapper. #3986

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Add 'BucketNotification.reload' API wrapper. #3986

merged 2 commits into from
Sep 18, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 16, 2017

Uses #3984 as a base.

Toward #3956.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 16, 2017
@tseaver tseaver requested review from ahmetb and dhermes September 16, 2017 14:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2017
@tseaver tseaver mentioned this pull request Sep 16, 2017
Closed
8 tasks
@ahmetb ahmetb removed their request for review September 17, 2017 23:56
dhermes
dhermes approved these changes Sep 18, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 7190c86 into googleapis:3956-storage-notifications Sep 18, 2017
@tseaver tseaver deleted the 3956-storage-notifications-notification-reload branch September 18, 2017 18:22
tseaver added a commit that referenced this pull request Sep 25, 2017
@tseaver
Add 'BucketNotification.{reload,exists}' API wrappers. (#3986)
2293eda 
Toward #3956.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot