Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language: Add classify_text method (v1). #4283

Merged
merged 5 commits into from
Nov 2, 2017
Merged

Conversation

lukesneeringer
Copy link
Contributor

This PR adds the classify_text method currently in the v1beta2 API version to the v1 version. This should be held until November 15 (the endpoint will not be live on v1 until then).

@lukesneeringer lukesneeringer added api: language Issues related to the Cloud Natural Language API API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 30, 2017
@lukesneeringer lukesneeringer self-assigned this Oct 30, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory LGTM

@lukesneeringer lukesneeringer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 1, 2017
@lukesneeringer
Copy link
Contributor Author

Okay, I tested this and am happy with it (but need to see what is up with CI).

@dhermes, I want to do the following:

  • I want to launch a new beta with these changes imminently (today if possible).
  • Next week (probably), I want to promote this to GA.

How does this interact with the releases you just did? I want to make sure I do not step on your toes.

@dhermes
Copy link
Contributor

dhermes commented Nov 1, 2017

@lukesneeringer I think it'd be fine to do two releases only (since you don't depend on a new version of core):

  • google-cloud-language==0.31.0
  • google-cloud==0.29.0 (which will have as the only change the dependence on the 0.31.x series of language

@dhermes dhermes force-pushed the language-v1-updates branch from 0155102 to fa1d8cd Compare November 1, 2017 23:35
@lukesneeringer
Copy link
Contributor Author

@dhermes Sounds good.

@lukesneeringer lukesneeringer merged commit 9247b99 into master Nov 2, 2017
@lukesneeringer lukesneeringer deleted the language-v1-updates branch November 2, 2017 15:24
parthea pushed a commit that referenced this pull request Jul 6, 2023
* Language: Add `classify_text` method (v1).
* Update v1beta2 also.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants